[PATCH] D157265: [AMDGPU] Reorder atomic optimizer to avoid CAS loop.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 09:24:00 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/r600.global_atomics.ll:2
+; RUN: llc -march=r600 -mcpu=cypress -amdgpu-atomic-optimizer-strategy=None -verify-machineinstrs < %s | FileCheck -check-prefix=EG -check-prefix=FUNC %s
+; RUN: llc -march=r600 -mcpu=cayman -amdgpu-atomic-optimizer-strategy=None -verify-machineinstrs < %s | FileCheck -check-prefix=EG -check-prefix=FUNC %s
 
----------------
pravinjagtap wrote:
> arsenm wrote:
> > It seems you're working around the pass not handling r600, can you just not add the pass in that case
> > It seems you're working around the pass not handling r600, can you just not add the pass in that case
> 
> are you suggesting to add atomic optimizer pass when `TM->getTargetTriple().getArch() == Triple::amdgcn` only ?
Yes 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157265/new/

https://reviews.llvm.org/D157265



More information about the llvm-commits mailing list