[PATCH] D157010: [llvm][ADT] Make `Twine` aware of `StringLiteral`

Jan Svoboda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 08:27:30 PDT 2023


jansvoboda11 added a comment.

In D157010#4564548 <https://reviews.llvm.org/D157010#4564548>, @dblaikie wrote:

> I'm confused - this patch was motivated by potential improvements to StringSaver, but https://reviews.llvm.org/D157015 says that those improvements can't be made because StringSaver must copy the data?

That's right. This gets used to avoid calling `StringSaver` in `CompilerInvocation.h` (D157046 <https://reviews.llvm.org/D157046>).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157010/new/

https://reviews.llvm.org/D157010



More information about the llvm-commits mailing list