[PATCH] D155956: [FunctionAttrs] Consider recursive argmem effects (PR63936)

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:178
+                       MemoryLocation::getBeforeOrAfter(Arg, I.getAAMetadata()),
+                       ArgMR);
+        }
----------------
Maximum depth on recursion?


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:185
       // have memory effects not described by the memory effects of the call
       // target.
       if (!Call->hasOperandBundles() && Call->getCalledFunction() &&
----------------
This comment needs to be updated.


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:246
 
-  return OrigME & ME;
+  return {OrigME & ME, RecursiveArgME};
 }
----------------
Style on `&`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155956/new/

https://reviews.llvm.org/D155956