[PATCH] D156707: AMDGPU: Handle multiple uses when matching sincos

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D156707#4565354 <https://reviews.llvm.org/D156707#4565354>, @Pierre-vh wrote:

> Do you think it's worth running a pass like InstSimplify after the tests to check the instruction does get eliminated?

No, it wouldn't be testing anything meaningful. If you don't have the right declaration attributes, it won't be deleted. You'd have to depend on the manually specified attributes in the test. The declarations in whatever source would have to be correct, or the attributes would have to be correct after linking (which is what actually happens)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156707/new/

https://reviews.llvm.org/D156707