[PATCH] D157100: [AMDGPU] Validate GDS in the assembler

Mon Aug 7 05:28:41 PDT 2023

foad marked an inline comment as done.
foad added a comment.

In D157100#4561296 <https://reviews.llvm.org/D157100#4561296>, @rampitec wrote:

> I think disasm test lines with gds shall also be removed, even if we still decode and print it.

I removed those lines and added a single test that the disassembler still decodes gds. Is that a reasonable compromise?

================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4428
+    SMLoc S = getImmLoc(AMDGPUOperand::ImmTyGDS, Operands);
+    Error(S, "gds modifier is not supported on this GPU");
+    return false;
----------------
kosarev wrote:
> Are there tests that check triggering this message?
Good point. There were not. I added one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157100/new/

https://reviews.llvm.org/D157100