[llvm] f7031c4 - [NFC] strengthen some CHECK-NOT lines

Sameer Sahasrabuddhe via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 04:20:37 PDT 2023


Author: Sameer Sahasrabuddhe
Date: 2023-08-07T16:50:03+05:30
New Revision: f7031c41eca3c9ea238c8cf96032ea7359943df5

URL: https://github.com/llvm/llvm-project/commit/f7031c41eca3c9ea238c8cf96032ea7359943df5
DIFF: https://github.com/llvm/llvm-project/commit/f7031c41eca3c9ea238c8cf96032ea7359943df5.diff

LOG: [NFC] strengthen some CHECK-NOT lines

The affected lit tests failed when they were run in a path that contained the
word "call". CHECK-NOT lines that were supposed to match only the IR ended up
matching the path printed in the output. Fixed this by checking for "call void"
instead.

Added: 
    

Modified: 
    llvm/test/Transforms/SampleProfile/inline-combine.ll
    llvm/test/Verifier/kcfi-operand-bundles.ll
    llvm/test/Verifier/ptrauth-operand-bundles.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/SampleProfile/inline-combine.ll b/llvm/test/Transforms/SampleProfile/inline-combine.ll
index aa26e5d087928d..3e980a7a2390fb 100644
--- a/llvm/test/Transforms/SampleProfile/inline-combine.ll
+++ b/llvm/test/Transforms/SampleProfile/inline-combine.ll
@@ -21,7 +21,7 @@ define void @foo(ptr %this) #0 align 2 !dbg !3 {
   store ptr %this, ptr %1, align 8
   %2 = load ptr, ptr %1, align 8
 ; the call should have been inlined after sample-profile pass
-; CHECK-NOT: call
+; CHECK-NOT: call void
   call void @bar(ptr %2), !dbg !7
   ret void
 }

diff  --git a/llvm/test/Verifier/kcfi-operand-bundles.ll b/llvm/test/Verifier/kcfi-operand-bundles.ll
index d9a3ce25d0a738..81431dd8e1d549 100644
--- a/llvm/test/Verifier/kcfi-operand-bundles.ll
+++ b/llvm/test/Verifier/kcfi-operand-bundles.ll
@@ -9,7 +9,7 @@ define void @test_kcfi_bundle(i64 %arg0, i32 %arg1, ptr %arg2) {
 ; CHECK-NEXT: call void %arg2() [ "kcfi"(i64 42) ]
   call void %arg2() [ "kcfi"(i64 42) ]
 
-; CHECK-NOT: call
+; CHECK-NOT: call void
   call void %arg2() [ "kcfi"(i32 42) ] ; OK
   call void %arg2() [ "kcfi"(i32 42) ] ; OK
   ret void

diff  --git a/llvm/test/Verifier/ptrauth-operand-bundles.ll b/llvm/test/Verifier/ptrauth-operand-bundles.ll
index 579a61c5cd6364..7aa5a22f7816f4 100644
--- a/llvm/test/Verifier/ptrauth-operand-bundles.ll
+++ b/llvm/test/Verifier/ptrauth-operand-bundles.ll
@@ -24,7 +24,7 @@ define void @test_ptrauth_bundle(i64 %arg0, i32 %arg1, ptr %arg2) {
 ; CHECK-NEXT: call void @g() [ "ptrauth"(i32 42, i64 120) ]
   call void @g() [ "ptrauth"(i32 42, i64 120) ]
 
-; CHECK-NOT: call
+; CHECK-NOT: call void
   call void %arg2() [ "ptrauth"(i32 42, i64 120) ]   ; OK
   call void %arg2() [ "ptrauth"(i32 42, i64 %arg0) ] ; OK
   ret void


        


More information about the llvm-commits mailing list