[PATCH] D154522: [DAG] Improve combineCarryDiamond to accept (uaddo_carry X, 0, Carry)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3576-3586
+  LLVM_DEBUG(
+    dbgs() << "Combine carry diamond:\n";
+    dbgs() << "\tCarry0: "; Carry0->dump();
+    dbgs() << "\tX: "; X->dump();
+    dbgs() << "\tY: "; Y->dump();
+    dbgs() << "\tCarry1: "; Carry1->dump();
+    dbgs() << "\tA: "; A->dump();
----------------
deadalnix wrote:
> idk if I shall keep this? This was tremendously useful when debugging.
Sure, but please can you tweak the "Combine carry diamond" top line to explain the position of each of the operands listed below


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154522/new/

https://reviews.llvm.org/D154522