[PATCH] D157108: APFloat: Add getExactLog2

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 01:47:17 PDT 2023


foad added inline comments.


================
Comment at: llvm/include/llvm/ADT/APFloat.h:493
+  // If this is an exact power of two, return the exponent. If it's not an exact
+  // power of 2, return INT_MIN
+  LLVM_READONLY
----------------
Do you intentionally ignore the sign bit? Should at least document that, since most people would not call -8 a power of two.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157108/new/

https://reviews.llvm.org/D157108



More information about the llvm-commits mailing list