[PATCH] D157002: [MachineCSE] Add an option to do machine cse at all time regardless of profitable checking

Mon Aug 7 00:59:35 PDT 2023

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Having a debug options is always useful. LGTM but I have some suggestions of the name.

================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:68

+static cl::opt<bool> AlwaysDoMachineCSE("always-do-machine-cse", cl::Hidden,
+                                        cl::init(false),
----------------
Maybe name this AggressiveMachineCSE or something like it, to try and show that it overrides the profitability but not correctness.

================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:70
+                                        cl::init(false),
+                                        cl::desc("Always do machine cse"));
+
----------------
Maybe "Override the profitability heuristics for Machine CSE"?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157002/new/

https://reviews.llvm.org/D157002