[PATCH] D156603: [SymbolSize] Improve the performance of SymbolSize computation

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 30 23:58:02 PDT 2023


jhenderson added inline comments.


================
Comment at: llvm/lib/Object/SymbolSize.cpp:89
+  // the same address, give both the same size. Because Addresses is sorted,
+  // using two pointers to keep track of the current symbol vs. the next symbol
+  // that doesn't have the same address for size computation.
----------------
Post commit nit "using" -> "use"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156603/new/

https://reviews.llvm.org/D156603



More information about the llvm-commits mailing list