[PATCH] D136264: [libunwind][RISCV] Support reading of VLENB CSR register
Catherine via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 30 20:59:25 PDT 2023
whitequark added a comment.
Herald added subscribers: wangpc, jobnoorman, asb.
I think this revision introduces a bug: namely, without Zicsr enabled, the code would not compile.
The code in `getRegister` should be wrapped in `#if defined(__riscv_zicsr)` and if it's not enabled then 0 would be returned. As I understand, the vector extension implies Zicsr.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136264/new/
https://reviews.llvm.org/D136264
More information about the llvm-commits
mailing list