[PATCH] D146054: [RISCV] Add --print-supported-extensions support

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:4340
+    }
+
   }
----------------
no blank line here


================
Comment at: clang/test/Driver/print-supported-extensions.c:93
+// CHECK-NEXT:	xventanacondops     1.0
+//
+//      CHECK:Experimental extensions
----------------
`//CHECK-EMPTY:`


================
Comment at: clang/test/Driver/print-supported-extensions.c:120
+// CHECK-NEXT:	ssaia               1.0
+//
+//      CHECK:Use -march to specify the target's extension.
----------------
`//CHECK-EMPTY:`


================
Comment at: clang/tools/driver/cc1_main.cpp:187
+/// Print supported extensions of the RISCV target.
+static void printSupportedExtensions() {
+  llvm::riscvExtensionsHelp();
----------------
The call site should just call riscvExtensionsHelp so that this internal linkage function can be avoided.


================
Comment at: clang/tools/driver/cc1_main.cpp:190
+}
+
+
----------------
one blank line


================
Comment at: clang/tools/driver/cc1_main.cpp:190
+}
+
+
----------------
MaskRay wrote:
> one blank line
one blank line


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:217
+  for (const auto &E : SupportedExtensions)
+    ExtMap[E.Name] = { E.Version.Major, E.Version.Minor };
+  for (const auto &E : ExtMap)
----------------
clang-format will remove the space after `{`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146054/new/

https://reviews.llvm.org/D146054