[PATCH] D156620: [InstCombine] Improve foldOpIntoPhi() to use isImpliedCondition

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:1370
+      if (ImpliedCond) {
+        APInt Constant(I.getType()->getScalarSizeInBits(), ImpliedCond.value());
+        NewPhiValues.push_back(
----------------
can rename variable from 'Constant'. Its a big confusing to have variable name ==type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156620/new/

https://reviews.llvm.org/D156620