[PATCH] D156087: [MLIR] Add index to side effect

donald chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 29 17:43:01 PDT 2023


cxy-1993 added a comment.

In D156087#4544491 <https://reviews.llvm.org/D156087#4544491>, @mehdi_amini wrote:

> There is likely some documentation to update.
>
> Also I'm not sure that "index" is expressive enough to carry the intent here. The closest I can relate here is pipeline stages in VLIW for example, so maybe the word "stage" should appear in the API?

Thank you for your insightful comments. Indeed, the index is not accurate in this scenario. I have made the necessary changes to the patch based on your feedback. Please review it again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156087/new/

https://reviews.llvm.org/D156087



More information about the llvm-commits mailing list