[PATCH] D156600: [llvm][NFC] Make test less brittle

[Nathan Sidwell via Phabricator via llvm-commits]

urnathan created this revision.
urnathan added a reviewer: nikic.
Herald added a subscriber: StephenFan.
Herald added a project: All.
urnathan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This test checks attributes by looking at the attribute dump.  That's both brittle and won't detect (some kinds of) attribute changes on functions. As it happens the memcpy changes I'm working on cause this test to spuriously fail as the attribute ordering is perturbed.

Make the test more robust by checking those on the actual function declarations.  In order to make the checks easier to write, it's better to run FileCheck twice -- once on stderr trace and once on the processed output.

Nikita -- you seem to have added the attribute checks?


https://reviews.llvm.org/D156600

Files:
  llvm/test/Analysis/BasicAA/cs-cs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156600.545380.patch
Type: text/x-patch
Size: 53321 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230729/d3969170/attachment.bin>