[PATCH] D156397: [FunctionAttrs] Unconditionally perform argument attribute inference in the first function-attrs pass

[Changpeng Fang via Phabricator via llvm-commits]

cfang marked 5 inline comments as done.
cfang added inline comments.


================
Comment at: llvm/test/Transforms/PhaseOrdering/arg-attrs-affect-earlycse.ll:3
+
+; CHECK: EarlyCSE CSE LOAD
+
----------------
aeubanks wrote:
> I don't think it's a good idea in these phase ordering tests to specifically check that a specific pass did something, future pipeline changes can break this; the whole point of these is that the entire pipeline gives a good result regardless of exactly what's happening in the pipelines. This should use `llvm/utils/update_test_checks.py` like the other phase ordering tests to check the final IR. Although I tried that for this test and this patch doesn't change it, so I think you'll need to change this test to get something where this patch actually improves something. Testing with `-memssa-check-limit=1` is fine though.
We could not successfully extract a small test from the huge application that can show the difference after the pipeline.
Would it be fine to check the IR after early-cse<memssa>? Thanks. and appreciate the the help and suggestions. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156397/new/

https://reviews.llvm.org/D156397