[PATCH] D155600: [AIX][TLS] Produce a faster local-exec access sequence with -maix-small-local-exec-tls (And optimize when load/store offsets are 0)

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 12:08:15 PDT 2023


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCMCInstLower.cpp:49
 
     TM.getNameWithPrefix(Name, GV, Mang);
+
----------------
This should be moved down past the early return.


================
Comment at: llvm/lib/Target/PowerPC/PPCMCInstLower.cpp:60
+        MO.getTargetFlags() & PPCII::MO_TPREL_FLAG) {
+      MCSymbol *Sym = AP.getSymbol(GV);
+      Sym->setOffset(MO.getOffset());
----------------
This can be `TM.getSymbol` like the `toc-data` case. No need for unnecessary differences between the two.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155600/new/

https://reviews.llvm.org/D155600



More information about the llvm-commits mailing list