[PATCH] D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 28 11:22:34 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:5114
+
+ ChangeStatus indicateOptimisticFixpoint() override {
+ return ChangeStatus::UNCHANGED;
----------------
sameerds wrote:
> Is it correct to say that an optimistic fix point is when all the "dynamic" components are set to default (`ieee`)? This attribute is reinventing what a fixed point means. Does this function need to set the optimistic fixed point? Or I would guess this function is actually never called, in which case it should be marked with `llvm_unreachable()`?
No. You cannot say IEEE is more optimistic than preserve-sign or positive-zero. They're just different. The only thing you can infer is known or unknown
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156129/new/
https://reviews.llvm.org/D156129
More information about the llvm-commits
mailing list