[PATCH] D156102: [AMDGPU] Don't suppress printing the .l and .h register suffixes.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 10:55:40 PDT 2023


kosarev added a comment.

> I believe those register classes which would print .l or .h on those targets pre-GFX11 are not used in any instruction actually selected by ISel. But if there was, this would change the default assembly printing for them. Can you verify that there are none? It is a similar question to the one raised here https://reviews.llvm.org/D156105#4540254

I don't see any operand definitions using VGPR_LO/HI16. I think any instructions using them would fail on MC tests; it's registers that have the suffixes, not register classes, so codegen should be irrelevant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156102/new/

https://reviews.llvm.org/D156102



More information about the llvm-commits mailing list