[PATCH] D155940: [SimplifyCFG] Transform for merging the combination of phis in switch

Hongyu Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 09:26:39 PDT 2023


XChy updated this revision to Diff 545192.
XChy added a comment.

- Refactor **TryToSimplifyUncondBranchFromEmptyBlock** to merge phis between BB and Succ with a common predecessor. Logic correctly embedded (OK in Local tests), but not efficient currently.
- A regression found, in **switch-simplify-crash2.ll**. But InstCombine would solve it.
- Testcases not added now, incoming. And ARM/jump-islands-table.ll doesn't test well still.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155940/new/

https://reviews.llvm.org/D155940

Files:
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/CodeGen/ARM/jump-table-islands.ll
  llvm/test/Transforms/SimplifyCFG/merge-phis-in-switch.ll
  llvm/test/Transforms/SimplifyCFG/switch-simplify-crash2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155940.545192.patch
Type: text/x-patch
Size: 19323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230728/7f255834/attachment.bin>


More information about the llvm-commits mailing list