[PATCH] D156202: [XCOFF] Do not put MergeableCStrings in their own section

[David Tenty via Phabricator via llvm-commits]

daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.

LGTM, with some notes:

This does constitute some kind of ABI change, since we're changing the name of certain symbols which have external linkage (if one module use the codegen before, and another after, the symbol will have different external names in the symbol table).
That said, in practice references would have been broken on the mismatch in name anyhow, as the external name with the extra prefix was already unexpected by the referencing side, so anything this breaks was likely already a problem.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156202/new/

https://reviews.llvm.org/D156202