[PATCH] D156532: [Pipelines] Perform hoisting prior to GVN

[Ramkumar Ramachandra via Phabricator via llvm-commits]

artagnon accepted this revision.
artagnon added a comment.
This revision is now accepted and ready to land.

LGTM based on benchmark runs.

Small improvement on upstream with no regressions:

  Program                                       upstream   upstream+nikic diff
  test-suite...xternal/CoreMark/coremark.test      1207474    1207474      0.0%
  test-suite...ternal/Embench/aha-mont64.test      2688858    2688858      0.0%
  test-suite...External/Embench/wikisort.test       890574     890574      0.0%
  test-suite :: External/Embench/ud.test           1997172    1997172      0.0%
  test-suite...xternal/Embench/statemate.test       115932     115932      0.0%
  test-suite :: External/Embench/st.test           3313229    3313229      0.0%
  test-suite... :: External/Embench/slre.test      2051440    2051440      0.0%
  test-suite...al/Embench/sglib-combined.test      2478118    2478118      0.0%
  test-suite... External/Embench/qrduino.test      2359823    2359823      0.0%
  test-suite...ternal/Embench/primecount.test      3926955    3926955      0.0%
  test-suite...External/Embench/picojpeg.test      2218597    2218597      0.0%
  test-suite...External/Embench/nsichneu.test      2309564    2309564      0.0%
  test-suite...nal/Embench/nettle-sha256.test      1757617    1757617      0.0%
  test-suite...ternal/Embench/nettle-aes.test      2241404    2241404      0.0%
  test-suite...:: External/Embench/nbody.test      3050149    3050149      0.0%
  test-suite...: External/Embench/minver.test       505186     505186      0.0%
  test-suite...: External/Embench/md5sum.test      1155937    1155937      0.0%
  test-suite...ernal/Embench/matmult-int.test      1270436    1270436      0.0%
  test-suite...xternal/Embench/huffbench.test      1768954    1768954      0.0%
  test-suite :: External/Embench/edn.test          2229782    2229782      0.0%
  test-suite...:: External/Embench/cubic.test      5219564    5219564      0.0%
  test-suite...:: External/Embench/crc32.test      2962144    2962144      0.0%
  test-suite...marks/Dhrystone/dhrystone.test       226782     226782      0.0%
  test-suite... External/Embench/tarfind.test   2139922189 2139605677     -0.0%

No changes downstream:

  Program                                       master  master+nikic diff
  test-suite...xternal/CoreMark/coremark.test   1028821 1028821       0.0%
  test-suite...ternal/Embench/aha-mont64.test   2478307 2478307       0.0%
  test-suite...External/Embench/wikisort.test    878540  878540       0.0%
  test-suite :: External/Embench/ud.test        1163530 1163530       0.0%
  test-suite... External/Embench/tarfind.test    984403  984403       0.0%
  test-suite...xternal/Embench/statemate.test     78614   78614       0.0%
  test-suite :: External/Embench/st.test        3329531 3329531       0.0%
  test-suite... :: External/Embench/slre.test   1723908 1723908       0.0%
  test-suite...al/Embench/sglib-combined.test   2359553 2359553       0.0%
  test-suite... External/Embench/qrduino.test   2132286 2132286       0.0%
  test-suite...ternal/Embench/primecount.test   3059021 3059021       0.0%
  test-suite...External/Embench/picojpeg.test   1820298 1820298       0.0%
  test-suite...External/Embench/nsichneu.test   2303401 2303401       0.0%
  test-suite...nal/Embench/nettle-sha256.test   1303960 1303960       0.0%
  test-suite...ternal/Embench/nettle-aes.test   1729373 1729373       0.0%
  test-suite...:: External/Embench/nbody.test   3043072 3043072       0.0%
  test-suite...: External/Embench/minver.test    398686  398686       0.0%
  test-suite...: External/Embench/md5sum.test    720967  720967       0.0%
  test-suite...ernal/Embench/matmult-int.test    990512  990512       0.0%
  test-suite...xternal/Embench/huffbench.test   1566315 1566315       0.0%
  test-suite :: External/Embench/edn.test       1161388 1161388       0.0%
  test-suite...:: External/Embench/cubic.test        44      44       0.0%
  test-suite...:: External/Embench/crc32.test   2788051 2788051       0.0%
  test-suite...marks/Dhrystone/dhrystone.test     98109   98109       0.0%


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156532/new/

https://reviews.llvm.org/D156532