[PATCH] D155894: [BPF] allow external calls

[Tamir Duberstein via Phabricator via llvm-commits]

tamird added a comment.

In D155894#4542263 <https://reviews.llvm.org/D155894#4542263>, @eddyz87 wrote:

> In D155894#4540874 <https://reviews.llvm.org/D155894#4540874>, @tamird wrote:
>
>> In D155894#4529382 <https://reviews.llvm.org/D155894#4529382>, @eddyz87 wrote:
>>
>>> If we want to report this for multiple functions I think we can set some flag and exit in `TargetLoweringBase::finalizeLowering()`.
>>
>> Doesn't this still run at the end of a function, rather than at the end of an entire file? We can report multiple functions have errored, but we can't emit all the errors in the file.
>
> Indeed it does. My bad, for some reason I thought it does so at the end of module. And I don't see any hook that could be executed at the end of the module. Still, imho, backend should not proceed with compilation in such cases even if only first error is reported.

Yes, we fixed the embedder. The question was is it possible to harden this such that future embedders don't make the same mistake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155894/new/

https://reviews.llvm.org/D155894