[PATCH] D156101: [AMDGPU] Introduce real and keep fake True16 instructions.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 06:18:49 PDT 2023


foad added a comment.

> It seems like only one terminology, be it 'fake16' or 'not16' is required; can we just use one? I prefer fake16. Please add a detailed description of the 'legacy', 'fake16' and 'true16' versions of 16-bit instructions and add it to the commit message and perhaps a comment.

Agreed. I believe this patch is the first time the term "fake16" has been used anywhere, so we need a clear explanation of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156101/new/

https://reviews.llvm.org/D156101



More information about the llvm-commits mailing list