[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.
Corentin Jabot via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 28 06:13:19 PDT 2023
cor3ntin added inline comments.
================
Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:100
+ for (auto ChIt = Name.begin(); ChIt != Name.end();
+ ChIt += IsBeforeMedial ? 3 : 1) {
+ char Ch = *ChIt;
----------------
aaron.ballman wrote:
> Parens here might be a kindness to folks who don't keep precedence rules in their head very well. ;-)
you are not wrong, I added parens!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156518/new/
https://reviews.llvm.org/D156518
More information about the llvm-commits
mailing list