[PATCH] D156315: [RFC][GlobalISel] Overhauled MIR Patterns Support for Combiners

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh updated this revision to Diff 545117.
Pierre-vh marked an inline comment as done.
Pierre-vh added a comment.

- Simplify temp reg emission using insertAction
- Fix immediate handling in `apply` patterns (check updated docs for the full breakdown).

Something I also want to point out is that a lot of the things here haven't been tested
in practice. I am confident that most things work just fine, but with this level of
complexity it's completely possible there's silly bugs here and there.
I'm anticipating that a lot of small fix patches will need to be made over time as
people start using MIR patterns and notice issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156315/new/

https://reviews.llvm.org/D156315

Files:
  llvm/docs/GlobalISel/MIRPatterns.rst
  llvm/docs/GlobalISel/index.rst
  llvm/docs/UserGuides.rst
  llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h
  llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h
  llvm/include/llvm/Target/GlobalISel/Combine.td
  llvm/lib/CodeGen/GlobalISel/GIMatchTableExecutor.cpp
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-imms.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-operand-types.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-patfrag-root.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-permutations.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-variadics.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/operand-types.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/patfrag-errors.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/pattern-errors.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/pattern-parsing-errors.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/pattern-parsing.td
  llvm/test/TableGen/GlobalISelEmitter.td
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/CodeGenTarget.h
  llvm/utils/TableGen/GlobalISel/CodeExpansions.h
  llvm/utils/TableGen/GlobalISel/CombinerUtils.h
  llvm/utils/TableGen/GlobalISelCombinerMatchTableEmitter.cpp
  llvm/utils/TableGen/GlobalISelEmitter.cpp
  llvm/utils/TableGen/GlobalISelMatchTable.h
  llvm/utils/TableGen/GlobalISelMatchTableExecutorEmitter.cpp
  llvm/utils/TableGen/GlobalISelMatchTableExecutorEmitter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156315.545117.patch
Type: text/x-patch
Size: 256485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230728/f6d5caae/attachment-0001.bin>