[PATCH] D156520: [TII] NFCI: Simplify the interface for isTriviallyReMaterializable

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 05:33:14 PDT 2023


sdesmalen added a comment.

In D156520#4541898 <https://reviews.llvm.org/D156520#4541898>, @arsenm wrote:

> This interface never made any sense

Agreed. I still find the need for `isReallyTriviallyReMaterializable()` a bit confusing, over simply having only `isTriviallyReMaterializable()`, but I didn't want to complicate this patch too much. It is possible to remove this layer, but that does complicate the overriden Target methods a bit more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156520/new/

https://reviews.llvm.org/D156520



More information about the llvm-commits mailing list