[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 28 05:04:55 PDT 2023
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:100
+ for (auto ChIt = Name.begin(); ChIt != Name.end();
+ ChIt += IsBeforeMedial ? 3 : 1) {
+ char Ch = *ChIt;
----------------
Parens here might be a kindness to folks who don't keep precedence rules in their head very well. ;-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156518/new/
https://reviews.llvm.org/D156518
More information about the llvm-commits
mailing list