[PATCH] D156458: GVNSink: add test to show GVN-aware sinking

[Ramkumar Ramachandra via Phabricator via llvm-commits]

artagnon marked an inline comment as done.
artagnon added inline comments.


================
Comment at: llvm/test/Transforms/GVNSink/gvn-awareness.ll:50
+  %beam.addr = alloca i32, align 4
+  %i = alloca i32, align 4
+  store ptr %a, ptr %a.addr, align 8
----------------
xbolva00 wrote:
> artagnon wrote:
> > nikic wrote:
> > > Please at least run this through SROA. The test is a weird mix of completely unoptimized IR plus a GVN replacement.
> > When I run it through SROA, `gvn-sink` no longer works.
> Maybe also add phaseordering test?
> 
> If this fails to work after sroa, than this optimization will not work anyway with -O2/-O3
Sorry, what do you mean by a phaseordering test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156458/new/

https://reviews.llvm.org/D156458