[PATCH] D156479: GlobalISel: Pass MachineIRBuilder to applyMappingImpl

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h:56
 
-  bool executeInWaterfallLoop(
-    MachineIRBuilder &B,
-    iterator_range<MachineBasicBlock::iterator> Range,
-    SmallSet<Register, 4> &SGPROperandRegs,
-    MachineRegisterInfo &MRI) const;
+  bool executeInWaterfallLoop(MachineIRBuilder &B,
+                              iterator_range<MachineBasicBlock::iterator> Range,
----------------
Pierre-vh wrote:
> Could we make the builder a member of the class? 
This is owned by the subtarget and shouldn’t be stateful. All the methods should be const 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156479/new/

https://reviews.llvm.org/D156479