[PATCH] D156413: [AMDGPU][PEI] Set up SP for chain functions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 04:07:24 PDT 2023


arsenm added a comment.

Can you add a test where this would need stack realignment? You should be able to bypass all of that stuff (I think we have a calling convention override for that already, you might set that somewhere else)



================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1094
+    if (UseSP) {
+      assert(StackPtrReg != AMDGPU::SP_REG);
+
----------------
We should probably get rid of SP_REG, it's always just hardcoded anyway


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156413/new/

https://reviews.llvm.org/D156413



More information about the llvm-commits mailing list