[PATCH] D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added a comment.

I confirmed all tests passing (with applying three diffs and generated blobs). Thanks.



================
Comment at: llvm/test/tools/llvm-cov/mcdc-const.test:4
+// RUN: llvm-profdata merge %S/Inputs/mcdc-const.proftext -o %t.profdata
+// RUN: llvm-cov show --show-branches=count --show-mcdc %S/Inputs/mcdc-const.o -instr-profile %t.profdata -path-equivalence=/tmp,%S/Inputs %S/Inputs/mcdc-const.cpp | FileCheck %s -check-prefix=CHECKGENERALCASE
+
----------------
alanphipps wrote:
> chapuni wrote:
> > I am afraid this would fail if LLVM is not configured for the arch of `mcdc-*.o`.
> Support for different binary formats is tested by binary-formats.c, but I'm not sure this matters for the documented coverage format anyway because it isn't architecture specific, unless I'm overlooking something.  I've not seen any issues with others tests in the same directory that follow the same pattern (e.g. branch-c-general.test et al.) that are also built for a single arch and binary format.
I generated wrong object `mcdc-const*.o`. (I didn't copy `mcdc-const*.cpp` to `/tmp`)
It caused test failures when directory layout differs.
Sorry for bothering you.

I have reconfirmed `mcdc-const*.o` generated on aarch64 working on amd64 as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138847/new/

https://reviews.llvm.org/D138847