[PATCH] D155485: Retain all jump table range checks when using BTI.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham added a comment.

In D155485#4541796 <https://reviews.llvm.org/D155485#4541796>, @chill wrote:

> Not sure about the `sed` usage, is it universally available (e.g. `llvm-lit` internal) or maybe the test would need `REQUIRES: system-linux` ?

I wasn't sure either, so I checked before deciding to use `sed` for the test preprocessing. The Software section of the Getting Started guide <https://llvm.org/docs/GettingStarted.html#software> lists `sed` as one of the expected tools on the compilation host. And other lit tests already exist that use `sed` in pipelines without any special `REQUIRES:` to authorise it – a quick grep finds, for example, `llvm/test/CodeGen/AArch64/speculation-hardening.ll`.

I guess that means if you're building and testing on Windows, it's up to you to arrange to have all those tools on Windows one way or another. (Perhaps the 'git bash' environment provides good-enough ones?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155485/new/

https://reviews.llvm.org/D155485