[PATCH] D154579: [InstCombine] Only perform one iteration

[Nikita Popov via Phabricator via llvm-commits]

nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:369
 
+static InstCombinePass createInstCombinePass() {
+  // InstCombine passes in the optimization pipeline should not verify that
----------------
aeubanks wrote:
> imo the `InstCombinePass` constructor should default to `no-verify-fixpoint`, but `parseInstCombineOptions` should by default set `verify-fixpoint`, since we typically call the `InstCombinePass` constructor from pass pipelines
Good point. In fact, I missed some InstCombinePass() uses in BackendUtil in the previous patch. Doing this in option parsing makes sure all C++ uses of InstCombinePass don't get fixpoint verification.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154579/new/

https://reviews.llvm.org/D154579