[PATCH] D156236: [RISCV] Make mapping symbols SF_FormatSpecific

Job Noorman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 01:16:49 PDT 2023


jobnoorman marked an inline comment as done.
jobnoorman added a comment.

In D156236#4541112 <https://reviews.llvm.org/D156236#4541112>, @MaskRay wrote:

> Due to how the llvm-nm code is currently constructed, consider adding tools/llvm-nm/special-syms-riscv.test as well.

I've opened D156514 <https://reviews.llvm.org/D156514> for this as some changes to llvm-nm were needed.



================
Comment at: llvm/test/DebugInfo/Symbolize/ELF/riscv-mapping-symbol.s:4
+
+# RUN: llvm-mc -filetype=obj -triple=riscv64 %s -o %t
+# RUN: llvm-symbolizer --obj=%t 0 4 0xc | FileCheck %s
----------------
MaskRay wrote:
> llvm-nm verification for other architectures is useful.
I'm not entirely sure what you mean by this. Are you talking about the special-syms test for llvm-nm?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156236/new/

https://reviews.llvm.org/D156236



More information about the llvm-commits mailing list