[PATCH] D156420: [TableGen] Add `!dump` and `dump`.
Francesco Petrogalli via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 28 01:13:55 PDT 2023
fpetrogalli added a comment.
In D156420#4541117 <https://reviews.llvm.org/D156420#4541117>, @wangpc wrote:
> Thanks! The implementation is just what I have imagined before!
Good good! Thank you for the review.
> One suggestion: can we accept variable-length arguments (at least one) and the first needn't to be a string? The output is just concatenation of all arguments and we make current implementation a special case. So that we can dump multiple values in a single line.
I'd keep it simple and avoid having to deal with variable-length args, because once D156429 <https://reviews.llvm.org/D156429> is in, we can achieve the same with `!dump("the concat is = ", !format("{0} {1}...", vars...))`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156420/new/
https://reviews.llvm.org/D156420
More information about the llvm-commits
mailing list