[PATCH] D156315: [RFC][GlobalISel] Overhauled MIR Patterns Support for Combiners

[Dominik Montada via Phabricator via llvm-commits]

gargaroff added a comment.

Awesome to finally see this, thanks for doing this! I checked the documentation and only had two minor nits.



================
Comment at: llvm/docs/GlobalISel/MIRPatterns.rst:290
+
+  // Here we pass $src, which is unbound, to does_not_bind.
+  // This cannot work because $x may not have been initialized in 'apply'.
----------------



================
Comment at: llvm/docs/GlobalISel/MIRPatterns.rst:298
+
+  // Here we pass $src, which is bound, to does_not_bind.
+  // This is fine because $x will always be bound when emitting does_not_bind
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156315/new/

https://reviews.llvm.org/D156315