[PATCH] D156407: [RISCV] Use max pushed register to get pushed register number.

Yeting Kuo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 19:03:35 PDT 2023


fakepaper56 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:1323
+    Register MaxReg = getMaxPushPopReg(*MF, CSI);
+    unsigned PushPopRegs =
+        getPushPopEncoding(MaxReg) - llvm::RISCVZC::RLISTENCODE::RA + 1;
----------------
Jim wrote:
> Should we ues PushPopNumRegs?
If we want to change the original name, I prefer PushedRegNum more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156407/new/

https://reviews.llvm.org/D156407



More information about the llvm-commits mailing list