[PATCH] D156049: [SPIR-V] Remove -opaque-pointers=0 from LITs, fixes for opaque pointers support

[Ilia Diachkov via Phabricator via llvm-commits]

iliya-diyachkov added a comment.

In general it looks good. Please keep failed tests to view the progress of development and allow others to troubleshoot.



================
Comment at: llvm/lib/Target/SPIRV/SPIRVDuplicatesTracker.h:27
 namespace llvm {
+using SPIRVType = const MachineInstr;
+
----------------
Is it used inside SPIRVDuplicatesTracker?


================
Comment at: llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp:936
   ResVReg = createTypeVReg(MIRBuilder);
+  SPIRVType *SpirvTy = MIRBuilder.buildInstr(Opcode).addDef(ResVReg);
   DT.add(Ty, &MIRBuilder.getMF(), ResVReg);
----------------
Does it affect DT?


================
Comment at: llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h:283
 
+  // TODO: Remove duplicate method
   SPIRVType *getOrCreateSPIRVPointerType(
----------------
It might be better to keep both interfaces removing duplication inside them.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp:1487
+  }
+  SPIRVType *ResType = GR.getOrCreateSPIRVPointerType(
+      PointerBaseType, I, TII,
----------------
Does it always have a pointer type?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156049/new/

https://reviews.llvm.org/D156049