[PATCH] D94964: [LangRef] Describe memory layout for vectors types

Thu Jul 27 16:05:00 PDT 2023

bjope added inline comments.

================
Comment at: llvm/docs/LangRef.rst:3253
+      ;    [%ptr + 0]: 01010011  (0x53)
+      ;    [%ptr + 1]: 00100001  (0x21)
+
----------------
danilaml wrote:
> bjope wrote:
> > danilaml wrote:
> > > Why is the least significant byte is placed at the largest memory address here, if it's little endian, just like for big endian?
> > > Shouldn't it be reversed?
> > @danilaml : Right, that indeed looks like a typo.
> > ```
> > store i16 0x5321, i16* %ptr
> > ```
> > would ofcourse put the 0x21 at the lower memory address. So this should say
> > 
> > ```
> > ;    [%ptr + 0]: 00100001  (0x21)
> > ;    [%ptr + 1]: 01010011  (0x53)
> > ```
> @bjope should I submit the fix as NFC or will you do it?
I've pushed a fixup here: https://reviews.llvm.org/rG9a53fe50f4355e6dfcd6af534cb394a62128963b

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94964/new/

https://reviews.llvm.org/D94964