[PATCH] D156488: [PPC] Fix layering issues between MCTargetDesc and CodeGen

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

Thank you for the patch. This is actually interesting and is a bit of a change to how we thought the code was do be structured. For us the affinity between CodeGen and MCTargetDesc was an indication that the libraries, although separate, are dependent on each other. Of course, this is not necessary so I am in favour of this refactoring.

I don't want to approve this patch immediately, not because I am opposed to it, but because I think it should be seen and reviewed by all interested developers for the PowerPC back end so that we can change the mindset about these libraries.

Finally, I wonder if we can add some tests that would prevent us from forming these dependencies again in the future? Is there a buildbot that uses Bazel? Immediate notification when new dependencies are re-introduced is essential to ensuring we stay on the straight and narrow wrt. to these libraries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156488/new/

https://reviews.llvm.org/D156488