[PATCH] D153039: [BOLT] A new code layout algorithm for function reordering [3b/3]

Thu Jul 27 15:34:58 PDT 2023

Amir accepted this revision.
Amir added a comment.
This revision is now accepted and ready to land.

Thanks! Can we add any tests for the expected layout, using either in-tree or upstream bolt-tests binaries and profiles? I don't see any for hfsort/hfsort+ but I think we want to avoid regressing the layout.

================
Comment at: bolt/lib/Passes/ReorderFunctions.cpp:340
+    std::vector<uint64_t> Result =
+        applyCDSLayout(FuncSizes, FuncCounts, CallCounts, CallOffsets);
+
----------------
I assume the definition lives in llvm/Transforms and we include the required component in CMakeLists?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153039/new/

https://reviews.llvm.org/D153039