[PATCH] D156389: [BOLT] Add support for instrumenting conditional tail calls

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 15:13:52 PDT 2023


Amir added a comment.

In D156389#4540222 <https://reviews.llvm.org/D156389#4540222>, @maksfb wrote:

> Thanks for the quick fix. Can we use instruction annotations instead of `IsCondTailCall` basic block property for the conditional tail call identification?

No, unfortunately we can't. Here's a counterexample (Ltmp3):
F28473662: image.png <https://reviews.llvm.org/F28473662>

The block ends with a tail call but we can't treat it as CondTailCall block as it's not created by removeConditionalTailCalls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156389/new/

https://reviews.llvm.org/D156389



More information about the llvm-commits mailing list