[PATCH] D156486: [AMDGPU] Avoid CodeGen dependencies from AMDGPU/Utils and MCTargetDesc

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 15:11:22 PDT 2023


rnk added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h:35
+/// Get the size in bits of a register from the register class \p RC.
+unsigned getRegBitWidth(const TargetRegisterClass &RC);
+} // namespace AMDGPU
----------------
arsenm wrote:
> Should go in SIRegisterInfo.h,, not AMDGPURegisterBankInfo (though I'm wondering why we need this in the first place, the MCRegisterClass one should work well enough?)
I moved it. `TargetRegisterClass` points to a `MCRegisterClass`, but they are not convertible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156486/new/

https://reviews.llvm.org/D156486



More information about the llvm-commits mailing list