[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

[Alan Phipps via Phabricator via llvm-commits]

alanphipps added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/InstrProfData.inc:661
 /* Raw profile format version (start from 1). */
-#define INSTR_PROF_RAW_VERSION 8
+#define INSTR_PROF_RAW_VERSION 9
 /* Indexed profile format version (start from 1). */
----------------
chapuni wrote:
> I guess you have forgot regenerating more a few input files.
> 
> * `Transforms/PGOProfile/memprof.ll`
Ah, ok -- good catch!  I did test with ZLIB enabled prior to when this test was added, but in my normal build, ZLIB is disabled, so it was skipped.  This appears to be the only case that otherwise fails. I reached out to the code owners and regenerated the proper inputs for this.

(Edit: code owners just landed a change to use proftext rather than profraw for the profile data).


================
Comment at: llvm/lib/ProfileData/InstrProfReader.cpp:725
+  // and not others. So if we record 0 bytes, just move on.
+  if (NumBitmapBytes == 0) {
+    return success();
----------------
paquette wrote:
> I think that clang-format will remove the braces here.
Hmm, it didn't catch it, but I can make the change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138846/new/

https://reviews.llvm.org/D138846