[PATCH] D156486: [AMDGPU] Avoid CodeGen dependencies from AMDGPU/Utils and MCTargetDesc

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 13:53:40 PDT 2023


rnk created this revision.
rnk added a reviewer: arsenm.
Herald added subscribers: foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
rnk requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This required two substantial changes:

1. Moving a `getRegBitWidth(TargetRegisterClass)` overload out of Utils and into CodeGen
2. Passing the string function name to AMDGPUPALMetadata instead of the MachineFunction

Other changes are minor or updates to accommodate the first two.

See issue #64166 for more information on the layering issue.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156486

Files:
  llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
  llvm/lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156486.544915.patch
Type: text/x-patch
Size: 8871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230727/ffa57bf7/attachment.bin>


More information about the llvm-commits mailing list