[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 13:33:56 PDT 2023


jdenny added a comment.

In D154984#4540226 <https://reviews.llvm.org/D154984#4540226>, @awarzynski wrote:

> Yes, that should work.

Thanks for confirming.  If others here like that proposal and are ok with not addressing external shells, then I'll prototype it and start thinking about an RFC.

> One could use `BASH_XTRACEFD` to redirect the debug output, but I'm not convinced that that would be an improvement.

It also seems limited to bash.  For example, there is a path in lit where it uses `/bin/sh`, which on my linux box is `dash`, which is "POSIX-compliant", "small as possible", and not bash.  And then there's also windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154984/new/

https://reviews.llvm.org/D154984



More information about the llvm-commits mailing list