[PATCH] D156479: GlobalISel: Pass MachineIRBuilder to applyMappingImpl

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 12:49:46 PDT 2023


arsenm created this revision.
arsenm added reviewers: aemerson, paquette, Pierre-vh, foad, Petar.Avramovic, mbrkusanin, nitinjohnraj, dsanders.
Herald added subscribers: StephenFan, kerbowa, pengfei, atanasyan, jrtc27, hiraditya, jvesely, sdardis.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

The target should not have to construct MachineIRBuilders during
RegBankSelect (we should perhaps hide the constructors for it). The
pass should own the builder setup with the desired CSE configuration
(although currently the pass does not use the CSE builder, which is
what I want to fix).


https://reviews.llvm.org/D156479

Files:
  llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
  llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
  llvm/include/llvm/CodeGen/RegisterBankInfo.h
  llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp
  llvm/lib/Target/AArch64/GISel/AArch64RegisterBankInfo.cpp
  llvm/lib/Target/AArch64/GISel/AArch64RegisterBankInfo.h
  llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h
  llvm/lib/Target/Mips/MipsRegisterBankInfo.cpp
  llvm/lib/Target/Mips/MipsRegisterBankInfo.h
  llvm/lib/Target/X86/X86RegisterBankInfo.cpp
  llvm/lib/Target/X86/X86RegisterBankInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156479.544895.patch
Type: text/x-patch
Size: 41772 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230727/c9c22b87/attachment.bin>


More information about the llvm-commits mailing list