[PATCH] D99750: [LV, VP]VP intrinsics support for the Loop Vectorizer

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9886
+
+          NewSI = Builder.CreateCall(
+              VPIntr, {StoredVal, VecPtr, BlockInMaskPart, EVLPart});
----------------
Should set the alignment attribute on the pointer operand.

Something like
```
NewSI->addParamAttr(1, Attribute::getWithAlignment(NewSI->getContext(), Alignment));
```


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9931
+
+        NewLI = Builder.CreateCall(VPIntr, {VecPtr, BlockInMaskPart, EVLPart},
+                                   "vp.op.load");
----------------
Should set the alignment attribute on the load.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99750/new/

https://reviews.llvm.org/D99750