[PATCH] D156468: [lld-macho]Avoid crashing in predicate functions.
Vy Nguyen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 27 11:05:40 PDT 2023
oontvoo created this revision.
Herald added projects: lld-macho, All.
Herald added a reviewer: lld-macho.
oontvoo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Querying the property of the Symbols via these is*() functions shouldn't crash the program - the answer should just be "false".
Currently, having them throw UNREACHABLE already (incorrectly) crash certain code paths involving macho::validateSymbolRelocation() .
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D156468
Files:
lld/MachO/Symbols.h
Index: lld/MachO/Symbols.h
===================================================================
--- lld/MachO/Symbols.h
+++ lld/MachO/Symbols.h
@@ -58,14 +58,14 @@
virtual uint64_t getVA() const { return 0; }
- virtual bool isWeakDef() const { llvm_unreachable("cannot be weak def"); }
+ virtual bool isWeakDef() const { return false; }
// Only undefined or dylib symbols can be weak references. A weak reference
// need not be satisfied at runtime, e.g. due to the symbol not being
// available on a given target platform.
virtual bool isWeakRef() const { return false; }
- virtual bool isTlv() const { llvm_unreachable("cannot be TLV"); }
+ virtual bool isTlv() const { return false; }
// Whether this symbol is in the GOT or TLVPointer sections.
bool isInGot() const { return gotIndex != UINT32_MAX; }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156468.544862.patch
Type: text/x-patch
Size: 839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230727/f0378914/attachment.bin>
More information about the llvm-commits
mailing list